feat: Implement row_range parameter support in SampleRowKeys API#13457
Open
anvitTawar wants to merge 2 commits into
Open
feat: Implement row_range parameter support in SampleRowKeys API#13457anvitTawar wants to merge 2 commits into
anvitTawar wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds convenience methods to BigtableDataClient for sampling row keys within a specified ByteStringRange both synchronously and asynchronously. It also updates SampleRowKeysRequest to support row ranges, adds proto conversion methods to ByteStringRange, and includes corresponding unit and integration tests. A review comment correctly identifies a typo in the Javadoc sample code where BigtableClient is used instead of BigtableDataClient, which would cause compilation errors.
| * <p>Sample code: | ||
| * | ||
| * <pre>{@code | ||
| * try (BigtableClient bigtableDataClient = BigtableClient.create("[PROJECT]", "[INSTANCE]")) { |
Contributor
There was a problem hiding this comment.
The sample code in the Javadoc uses BigtableClient instead of BigtableDataClient. This will cause compilation errors if copied directly.
Suggested change
| * try (BigtableClient bigtableDataClient = BigtableClient.create("[PROJECT]", "[INSTANCE]")) { | |
| * try (BigtableDataClient bigtableDataClient = BigtableDataClient.create("[PROJECT]", "[INSTANCE]")) { |
References
- Update stale Javadoc comments to reflect new method behavior for improved clarity, rather than removing them.
Expose rowRange property of type ByteStringRange on SampleRowKeysRequest wrapper and its builder. Map rowRange to protobuf row_range in toProto() and read it back in fromProto(). Add convenience methods to BigtableDataClient. Add unit tests and integration tests. TAG=agy CONV=015d968b-2de3-4c29-8f2d-8acdf06f6135
anvitTawar
force-pushed
the
sample-row-keys-row-range
branch
from
a3dd1c9 to
ab72c9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose rowRange property of type ByteStringRange on SampleRowKeysRequest wrapper and its builder. Map rowRange to protobuf row_range in toProto() and read it back in fromProto(). Add convenience methods to BigtableDataClient.
Add unit tests and integration tests.